Fix conftest dependency breaking nightly wheel build#3078
Merged
kevinjqliu merged 7 commits intoapache:mainfrom Feb 22, 2026
Merged
Fix conftest dependency breaking nightly wheel build#3078kevinjqliu merged 7 commits intoapache:mainfrom
kevinjqliu merged 7 commits intoapache:mainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+205
to
+225
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v6 | ||
| - uses: actions/setup-python@v6 | ||
| with: | ||
| python-version: '3.12' | ||
| - name: Install UV | ||
| uses: astral-sh/setup-uv@v7 | ||
| with: | ||
| enable-cache: true | ||
| # Why this exists: | ||
| # Catch import-time regressions (e.g., global conftest optional deps) | ||
| # in the same dev-only environment used by cibuildwheel wheel tests. | ||
| # Keep this in sync with wheel build test setup in | ||
| # .github/workflows/pypi-build-artifacts.yml: | ||
| # CIBW_BEFORE_TEST: uv sync --directory {project} --only-group dev --no-install-project | ||
| # CIBW_TEST_COMMAND: uv run --directory {project} pytest tests/avro/test_decoder.py | ||
| - name: Mirror wheel CIBW_BEFORE_TEST | ||
| run: uv sync --directory . --only-group dev --no-install-project | ||
| - name: Mirror wheel CIBW_TEST_COMMAND | ||
| run: uv run --directory . pytest tests/avro/test_decoder.py |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Contributor
Author
There was a problem hiding this comment.
will fix this separately
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Context: #2982 (comment)
Adding imports to
conftest.pymay break the nightly build pipeline. (For example BigQuery in #2982).This is because nightly wheel build tests run in a narrower dependency set (
--only-group dev), so new imports could cause test collection to fail.This PR inlines the imports in
conftest.pyand also include a smoke test in CI to catch this problem going forwardAre these changes tested?
yes, nightly build works again https://github.com/apache/iceberg-python/actions/runs/22285169782
Are there any user-facing changes?