Open
Conversation
arturobernalg
force-pushed
the
trailerHeaderFields
branch
from
9117280 to
30b6149
Compare
ok2c
requested changes
Feb 17, 2026
| } | ||
| } | ||
|
|
||
| static void verifyOutbound(final List<? extends Header> trailers) throws H2ConnectionException { |
Member
There was a problem hiding this comment.
@arturobernalg Use H2ConnectionException everywhere and eliminate the other method.
Reject pseudo-headers in inbound and outbound trailers
arturobernalg
force-pushed
the
trailerHeaderFields
branch
from
ed8b1d7 to
7eb9854
Compare
ok2c
approved these changes
Feb 17, 2026
Member
ok2c
left a comment
ok2c
left a comment
There was a problem hiding this comment.
@arturobernalg Please give this pull request a more descriptive title.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.