Skip to content

Change exception treatment on incremental snapshot wait#12665

Open
JoaoJandre wants to merge 2 commits intoapache:mainfrom
scclouds:ignore-exception
Open

Change exception treatment on incremental snapshot wait#12665
JoaoJandre wants to merge 2 commits intoapache:mainfrom
scclouds:ignore-exception

Conversation

@JoaoJandre
Copy link
Contributor

Description

During the KVM incremental volume snapshot creation process, ACS waits for Libvirt's backup-begin command to finish; during this period, there is a possibility that the thread that is waiting is interrupted, if that happens, an exception is thrown and the snapshot fails.

This PR changes the exception handling so that the thread only informs that it was interrupted in the logs and goes back to waiting for the Libvirt process to finish.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 17.92%. Comparing base (30e6c22) to head (aef2026).

Files with missing lines Patch % Lines
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main   #12665   +/-   ##
=========================================
  Coverage     17.92%   17.92%           
- Complexity    16154    16155    +1     
=========================================
  Files          5939     5939           
  Lines        533181   533181           
  Branches      65237    65237           
=========================================
  Hits          95585    95585           
  Misses       426856   426856           
  Partials      10740    10740           
Flag Coverage Δ
uitests 3.67% <ø> (ø)
unittests 19.03% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a bug in the KVM incremental volume snapshot creation process where thread interruptions during the wait for Libvirt's backup-begin command would cause snapshot failures. The change modifies the exception handling to log interruptions and continue waiting instead of throwing an exception.

Changes:

  • Modified exception handling in waitForBackup() to log InterruptedException at trace level and continue waiting instead of throwing CloudRuntimeException

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…/storage/KVMStorageProcessor.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments