backport: PR 11914 fixing MS maintenance test

[shwstppr]

Description

Backport #PR11914
A few tests in ManagementServerMaintenanceManagerImplTest need correction, as they currently invoke test class methods multiple times within the same test case.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[shwstppr]

Facing build issues with BO on 4.22 branch

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

[sureshanaparti]

@shwstppr target branch should be 4.22 here?

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.90%. Comparing base (7324ef4) to head (11752ae).

Additional details and impacted files

@@             Coverage Diff              @@
##               4.22   #12623      +/-   ##
============================================
+ Coverage     17.62%   17.90%   +0.27%     
- Complexity    15668    16094     +426     
============================================
  Files          5917     5938      +21     
  Lines        531255   532864    +1609     
  Branches      64951    65192     +241     
============================================
+ Hits          93639    95394    +1755     
+ Misses       427077   426792     -285     
- Partials      10539    10678     +139     

Flag	Coverage Δ
uitests	3.67% <ø> (-0.03%)	⬇️
unittests	19.00% <ø> (+0.30%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[shwstppr]

@sureshanaparti thanks, my bad

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 16774

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16778

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[sureshanaparti]

clgtm

[blueorangutan]

[SF] Trillian test result (tid-15427)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 50785 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12623-t15427-kvm-ol8.zip
Smoke tests completed. 146 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestListIdsParams>:teardown	Error	1.17	test_list_ids_parameter.py
test_01_snapshot_root_disk	Error	5.97	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	Error	49.83	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	Error	49.84	test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:teardown	Error	32.71	test_snapshots.py
test_01_snapshot_usage	Error	22.82	test_usage.py
test_01_vpn_usage	Error	1.11	test_usage.py

[weizhouapache]

code lgtm

however, i did not see the test failures with simulator CI or packaging jobs.