Skip to content

Fix warnings due to changes on Unity 6.5#655

Open
thomas-tu wants to merge 2 commits intomasterfrom
bugfix/fix-warnings
Open

Fix warnings due to changes on Unity 6.5#655
thomas-tu wants to merge 2 commits intomasterfrom
bugfix/fix-warnings

Conversation

@thomas-tu
Copy link
Collaborator

DO NOT FORGET TO INCLUDE A CHANGELOG ENTRY

Purpose of this PR

This PR bring mandatory changes due to recent updates on U6.5.

[Brief summary of the changes in this PR.]

Links

Jira:

Comments to Reviewers

[List known issues, planned work, provide any extra context for your code.]

@u-pr
Copy link

u-pr bot commented Feb 25, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

The PR contains straightforward preprocessor directive updates to accommodate Unity 6000.5 API changes.

🏅 Score: 100

The changes cleanly address the Unity 6.5 warnings using proper compiler directives, maintaining backward compatibility without introducing complexity.

🧪 PR contains tests
🔒 No security concerns identified
⚡ No major issues detected
  • Update review

🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr

@u-pr
Copy link

u-pr bot commented Feb 25, 2026

PR Code Suggestions ✨

No code suggestions found for the PR.

@codecov-github-com
Copy link

codecov-github-com bot commented Feb 25, 2026

Codecov Report

All modified and coverable lines are covered by tests ✅

@@           Coverage Diff           @@
##           master     #655   +/-   ##
=======================================
  Coverage   36.05%   36.06%           
=======================================
  Files         277      277           
  Lines       34909    34910    +1     
=======================================
+ Hits        12588    12589    +1     
  Misses      22321    22321           
Flag Coverage Δ
probuilder_MacOS_6000.0 34.58% <ø> (ø)
probuilder_MacOS_6000.3 34.58% <ø> (ø)
probuilder_MacOS_6000.4 34.57% <ø> (ø)
probuilder_MacOS_6000.5 34.57% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
Editor/EditorCore/EditorUtility.cs 49.75% <100.00%> (+0.24%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.


internal static T[] FindObjectsByType<T>() where T : UObject
{
#if UNITY_6000_5_OR_NEWER

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems need to be UNITY_6000_4_OR_NEWER.
The deprecation happens starting from 6000.4,
see UnityEngineObject.bindings.cs at line 53 in 6000.4 branch.


instance.PerformAction();

#if UNITY_6000_5_OR_NEWER

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same as above


Undo.PerformUndo();

#if UNITY_6000_5_OR_NEWER

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants