Improve Error Handling with Serialized File Detection#58
Open
SkowronskiAndrew wants to merge 5 commits intoimprove-error-handlingfrom
Open
Improve Error Handling with Serialized File Detection#58SkowronskiAndrew wants to merge 5 commits intoimprove-error-handlingfrom
SkowronskiAndrew wants to merge 5 commits intoimprove-error-handlingfrom
Conversation
Use detection helpers to print more informative messages when command is run against the wrong file type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add detection for serialized files by looking inside the file and checking expected content.
This allows "analyze" to more accurately ignore unsupported files that can be found in the scanning location.
Previously we tried to open it using the actual parsing code in UnityFileSystem which could throw unexpected or misleading errors.
Now only if the header check passes will we attempt to load it.
Fix includes test coverage, including files from an older version of Unity.
Also cleanup the previously existing check for Unity Archive files