FIX: New Input System warning dialog is misleading when not using input system

[josepmariapujol-unity]

Description

This PR is fixing the InputSystem warning dialog after we received some complains on forums.
In 2022.3, there is not checkbox displaying thus splitting logic between editor verions.

JIRA: https://jira.unity3d.com/browse/UUM-132151

Testing status & QA

Before:

After:

Overall Product Risks

Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.

• Complexity: 0
• Halo Effect: 0

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

• Changelog entry added.
  • Explains the change in Changed, Fixed, Added sections.
  • For API change contains an example snippet and/or migration example.
  • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
  • Jira port for the next release set as "Resolved".
• Tests added/changed, if applicable.
  • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
  • Performance tests.
  • Integration tests.
• Docs for new/changed API's.
  • Xmldoc cross references are set correctly.
  • Added explanation how the API works.
  • Usage code examples added.
  • The manual is updated, if needed.

During merge:

• Commit message for squash-merge is prefixed with one of the list:
  • NEW: ___.
  • FIX: ___.
  • DOCS: ___.
  • CHANGE: ___.
  • RELEASE: 1.1.0-preview.3.

[u-pr]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪ The PR consists of a simple text update and improved dialog options, wrapped in a compiler directive for backward compatibility.

🏅 Score: 100 The code is clean, correctly handles backward compatibility, and significantly improves the UX of the warning dialog by providing a clearer message and a session-based opt-out.

🧪 No relevant tests

🔒 No security concerns identified

⚡ No major issues detected

Update review

---

🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr

[u-pr]

PR Code Suggestions ✨

No code suggestions found for the PR.

[codecov-github-com]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...s/com.unity.inputsystem/InputSystem/InputSystem.cs	0.00%	3 Missing ⚠️

@@             Coverage Diff             @@
##           develop    #2358      +/-   ##
===========================================
- Coverage    77.90%   77.89%   -0.02%     
===========================================
  Files          476      476              
  Lines        97613    97611       -2     
===========================================
- Hits         76048    76034      -14     
- Misses       21565    21577      +12     

Flag	Coverage Δ
inputsystem_MacOS_2022.3	5.52% <0.00%> (-0.01%)	⬇️
inputsystem_MacOS_2022.3_project	75.39% <0.00%> (-0.01%)	⬇️
inputsystem_MacOS_6000.0	5.30% <0.00%> (-0.01%)	⬇️
inputsystem_MacOS_6000.0_project	77.29% <0.00%> (-0.01%)	⬇️
inputsystem_MacOS_6000.3	5.31% <0.00%> (-0.01%)	⬇️
inputsystem_MacOS_6000.3_project	77.29% <0.00%> (-0.01%)	⬇️
inputsystem_MacOS_6000.4	5.31% <0.00%> (-0.01%)	⬇️
inputsystem_MacOS_6000.4_project	77.30% <0.00%> (-0.01%)	⬇️
inputsystem_MacOS_6000.5	5.31% <0.00%> (-0.01%)	⬇️
inputsystem_MacOS_6000.5_project	77.29% <0.00%> (-0.01%)	⬇️
inputsystem_MacOS_6000.6	5.31% <0.00%> (-0.01%)	⬇️
inputsystem_MacOS_6000.6_project	77.29% <0.00%> (-0.01%)	⬇️
inputsystem_Ubuntu_2022.3	5.53% <0.00%> (-0.01%)	⬇️
inputsystem_Ubuntu_2022.3_project	75.19% <0.00%> (-0.01%)	⬇️
inputsystem_Ubuntu_6000.0	5.31% <0.00%> (-0.01%)	⬇️
inputsystem_Ubuntu_6000.0_project	77.09% <0.00%> (-0.01%)	⬇️
inputsystem_Ubuntu_6000.3	5.31% <0.00%> (-0.01%)	⬇️
inputsystem_Ubuntu_6000.3_project	77.09% <0.00%> (-0.01%)	⬇️
inputsystem_Ubuntu_6000.4	5.32% <0.00%> (-0.01%)	⬇️
inputsystem_Ubuntu_6000.4_project	77.10% <0.00%> (-0.01%)	⬇️
inputsystem_Ubuntu_6000.5	5.32% <0.00%> (-0.01%)	⬇️
inputsystem_Ubuntu_6000.5_project	77.10% <0.00%> (-0.02%)	⬇️
inputsystem_Ubuntu_6000.6	5.32% <0.00%> (-0.01%)	⬇️
inputsystem_Ubuntu_6000.6_project	77.10% <0.00%> (-0.01%)	⬇️
inputsystem_Windows_2022.3	5.53% <0.00%> (-0.01%)	⬇️
inputsystem_Windows_2022.3_project	75.52% <0.00%> (-0.01%)	⬇️
inputsystem_Windows_6000.0	5.30% <0.00%> (-0.01%)	⬇️
inputsystem_Windows_6000.0_project	77.42% <0.00%> (-0.01%)	⬇️
inputsystem_Windows_6000.3	5.31% <0.00%> (-0.01%)	⬇️
inputsystem_Windows_6000.3_project	77.42% <0.00%> (-0.01%)	⬇️
inputsystem_Windows_6000.4	5.31% <0.00%> (-0.01%)	⬇️
inputsystem_Windows_6000.4_project	77.42% <0.00%> (-0.01%)	⬇️
inputsystem_Windows_6000.5	5.31% <0.00%> (-0.01%)	⬇️
inputsystem_Windows_6000.5_project	77.42% <0.00%> (+<0.01%)	⬆️
inputsystem_Windows_6000.6	5.31% <0.00%> (-0.01%)	⬇️
inputsystem_Windows_6000.6_project	77.42% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...s/com.unity.inputsystem/InputSystem/InputSystem.cs	84.27% <0.00%> (-0.11%)	⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jfreire-unity]

I added a suggestion but its probably better to pass it by who open the ticket IMO. I don't think "Native Device Inputs Not Enabled" makes a lot of sense. This is not about devices not being enabled (that's one of consequences), but rather the whole native platform backend not being enabled.
It's a nit pick anyway but it didn't read so well.

[jfreire-unity]

Thanks @josepmariapujol-unity !

[marnadeau]

Thank you!