Skip to content

Comments

Add time and space complexity documentation to LongestNonRepetitiveSubstring#7283

Closed
eMohan07 wants to merge 1 commit intoTheAlgorithms:masterfrom
eMohan07:add-complexity-longest-substring
Closed

Add time and space complexity documentation to LongestNonRepetitiveSubstring#7283
eMohan07 wants to merge 1 commit intoTheAlgorithms:masterfrom
eMohan07:add-complexity-longest-substring

Conversation

@eMohan07
Copy link
Contributor

This pull request adds detailed time and space complexity documentation to the method
lengthOfLongestSubstring in LongestNonRepetitiveSubstring.java.

The update improves clarity by explaining the efficiency of the sliding window
approach used in the implementation. No functional changes have been made.

Type of Change

  • Documentation update

Checklist

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • No functional changes introduced.
  • Code compiles successfully.

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2026

Codecov Report

❌ Patch coverage is 88.18227% with 236 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.34%. Comparing base (29ce2ef) to head (2befeec).

Files with missing lines Patch % Lines
.../java/com/thealgorithms/ciphers/ProductCipher.java 0.00% 44 Missing ⚠️
.../com/thealgorithms/backtracking/MazeRecursion.java 55.55% 12 Missing and 4 partials ⚠️
.../java/com/thealgorithms/ciphers/ElGamalCipher.java 57.89% 6 Missing and 10 partials ⚠️
...java/com/thealgorithms/ciphers/PlayfairCipher.java 80.48% 12 Missing and 4 partials ⚠️
...lgorithms/ciphers/ColumnarTranspositionCipher.java 78.12% 11 Missing and 3 partials ⚠️
...va/com/thealgorithms/backtracking/KnightsTour.java 75.55% 5 Missing and 6 partials ⚠️
...a/com/thealgorithms/backtracking/SudokuSolver.java 73.80% 10 Missing and 1 partial ⚠️
...n/java/com/thealgorithms/backtracking/NQueens.java 68.75% 10 Missing ⚠️
.../java/com/thealgorithms/ciphers/AESEncryption.java 66.66% 9 Missing ⚠️
src/main/java/com/thealgorithms/ciphers/DES.java 92.74% 6 Missing and 3 partials ⚠️
... and 29 more
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #7283   +/-   ##
=========================================
  Coverage     79.34%   79.34%           
  Complexity     7006     7006           
=========================================
  Files           784      784           
  Lines         22992    22992           
  Branches       4516     4516           
=========================================
  Hits          18242    18242           
  Misses         4020     4020           
  Partials        730      730           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eMohan07 eMohan07 force-pushed the add-complexity-longest-substring branch from 84e8127 to a4a684e Compare February 20, 2026 17:59
@eMohan07 eMohan07 force-pushed the add-complexity-longest-substring branch from a4a684e to 2befeec Compare February 20, 2026 18:05
@eMohan07 eMohan07 marked this pull request as ready for review February 20, 2026 18:09
@vil02
Copy link
Member

vil02 commented Feb 20, 2026

There is something clearly wrong with this change - the diff does not match the description.

@vil02 vil02 closed this Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants