fix(logging): Replace printStackTrace() with proper logging#850
Merged
TommyLemon merged 1 commit intoTencent:masterfrom Feb 18, 2026
Merged
Conversation
Replace all e.printStackTrace() calls with Log.e() to follow best practices for error handling and logging. This provides: - Consistent logging format with timestamps - Better error tracking in production - Ability to control logging via Log.DEBUG flag - More meaningful error messages with context Changes: - AbstractSQLExecutor.java: 9 replacements - AbstractParser.java: 6 replacements - JSONRequest.java: 1 replacement - JSR223ScriptExecutor.java: 1 replacement Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Collaborator
|
@hobostay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace all
e.printStackTrace()calls withLog.e()to follow best practices for error handling and logging.Changes
This PR replaces all instances of
e.printStackTrace()with proper logging using the project'sLog.e()method, providing:Log.DEBUGflagFiles Modified
AbstractSQLExecutor.java: 9 replacements (ResultSet close, transaction errors, connection close)AbstractParser.java: 6 replacements (parse errors, transaction commit/rollback)JSONRequest.java: 1 replacement (JSON parse error)JSR223ScriptExecutor.java: 1 replacement (script compilation error)Type
Checklist
Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com