Skip to content

[CSSGapDecorations] Refresh explainer with new outset properties#1180

Open
jav099 wants to merge 4 commits intoMicrosoftEdge:mainfrom
jav099:main
Open

[CSSGapDecorations] Refresh explainer with new outset properties#1180
jav099 wants to merge 4 commits intoMicrosoftEdge:mainfrom
jav099:main

Conversation

@jav099
Copy link

@jav099 jav099 commented Oct 27, 2025

@jav099
Copy link
Author

jav099 commented Nov 10, 2025

@microsoft-github-policy-service agree company="Microsoft"

Copy link
Member

@kbabbitt kbabbitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking this morning at updating the explainer and came across this PR which completely fell off my radar, sorry about that. @jav099 could you switch "outset" to "inset" throughout and then we can land it?

Comment on lines 219 to 220
The "zero point" is the edge of the intersection, with positive values extending
into the intersection and negative values receding from it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
into the intersection and negative values receding from it.
The "zero point" is the edge of the intersection, with negative values extending
into the intersection and positive values receding from it.

.outset-5px {
column-rule-outset: 5px;
.inset-5px {
column-rule-inset: 5px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to flip signs on inset values in example text? And/or update example image names to reflect the insets they're depicting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants