feat!: Expose Accounts-owned controller/service methods through messenger by GuillaumeRx · Pull Request #7976 · MetaMask/core

GuillaumeRx · 2026-02-18T11:14:53Z

Explanation

Exposes all the public methods other than init or any internally used methods of the accounts-owned controllers/services throught the messenger.

This also refactors how actions are defined and bound to the messenger using registerMethodActionHandlers and MESSENGER_EXPOSED_METHODS.

The generate-method-action-type script was used to generate the action types.

This is a breaking change in the profile-sync-controller package as some of the action type names changed but none of the underlying signatures changed.

References

Checklist

I've updated the test suite for new or updated code as appropriate
I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
I've communicated my changes to consumers by updating changelogs for packages I've changed
I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
Expands messenger-exposed surface area and refactors action handler registration across multiple controllers/services; while behavior should be equivalent, consumers may break due to renamed action types (not strings) and removed internal-only methods.

Overview
Exposes additional public methods on AccountTreeController, AccountsController, MultichainAccountService, AuthenticationController, and UserStorageController through their messengers by switching to registerMethodActionHandlers with a centralized MESSENGER_EXPOSED_METHODS list.

Introduces auto-generated *-method-action-types.ts files (and package scripts/dependency on tsx) and updates exports/changelogs accordingly; internal-only helpers are made private/removed from the public API (e.g., AccountsController#getAccountExpect, AccountTreeController#resolveNameConflict) and tests are updated to use the remaining public methods.

Standardizes profile-sync-controller messenger action type names to end in Action and updates downstream AllowedActions type references across other packages (bridge, assets, notifications, subscription, etc.).

^{Written by Cursor Bugbot for commit 5705479. This will update automatically on new commits. Configure here.}

GuillaumeRx · 2026-02-18T11:16:15Z

packages/account-tree-controller/src/AccountTreeController.test.ts

+      controller.setAccountGroupName(groupId, 'Suffix Test', true);

-      // Test with no conflicts: should return "Unique Name (2)"
-      const uniqueName = controller.resolveNameConflict(
-        wallet,
-        groupId,
-        'Unique Name',
-      );
-      expect(uniqueName).toBe('Unique Name (2)');
+      const collidingGroupObject = controller.getAccountGroupObject(groupId);
+
+      expect(collidingGroupObject?.metadata.name).toBe('Suffix Test (3)');
+
+      // Test with no conflicts: should return "Unique Name"
+      controller.setAccountGroupName(groupId, 'Unique Name', true);
+
+      const uniqueGroupObject = controller.getAccountGroupObject(groupId);
+
+      expect(uniqueGroupObject?.metadata.name).toBe('Unique Name');


resolveNameConflict is only internally used. It doesn't make sense to have it publicly only to test its behavior in unit tests. We can do that via the public methods that uses it

I can confirm this is not used in either extension and mobile.

GuillaumeRx · 2026-02-18T11:17:30Z

packages/account-tree-controller/src/AccountTreeController.test.ts

+      controller.setAccountGroupName(groupId, 'Suffix Test', true);

-      // Test with no conflicts: should return "Unique Name (2)"
-      const uniqueName = controller.resolveNameConflict(
-        wallet,
-        groupId,
-        'Unique Name',
-      );
-      expect(uniqueName).toBe('Unique Name (2)');
+      const collidingGroupObject = controller.getAccountGroupObject(groupId);
+
+      expect(collidingGroupObject?.metadata.name).toBe('Suffix Test (3)');
+
+      // Test with no conflicts: should return "Unique Name"
+      controller.setAccountGroupName(groupId, 'Unique Name', true);
+
+      const uniqueGroupObject = controller.getAccountGroupObject(groupId);
+
+      expect(uniqueGroupObject?.metadata.name).toBe('Unique Name');


This assertion was very misleading by the way. If there's no conflict the method shouldn't be called therefore no suffix should be added.

GuillaumeRx · 2026-02-18T11:18:28Z

packages/accounts-controller/src/AccountsController.ts

   * @throws An error if the account ID is not found.
   */
-  getAccountExpect(accountId: string): InternalAccount {
+  #getAccountExpect(accountId: string): InternalAccount {


We don't need this method to be public, it's only used internally.

Makes sense!

packages/profile-sync-controller/src/controllers/user-storage/UserStorageController.ts

packages/account-tree-controller/src/types.ts

packages/profile-sync-controller/src/controllers/authentication/AuthenticationController.ts

packages/profile-sync-controller/src/controllers/user-storage/UserStorageController.ts

GuillaumeRx · 2026-02-19T15:14:58Z

packages/profile-sync-controller/src/controllers/authentication/index.ts

I don't know what's going on here with the imports, I just made sure that the original export behavior was respected.

This certainly seems cleaner :)

GuillaumeRx · 2026-02-19T15:15:18Z

packages/profile-sync-controller/src/controllers/user-storage/index.ts

I don't know what's going on here with the imports, I just made sure that the original export behavior was respected.

packages/account-tree-controller/src/types.ts

GuillaumeRx · 2026-02-20T13:01:05Z

packages/multichain-account-service/src/MultichainAccountService.test.ts

+      const { messenger, mocks } = await setup({
        accounts: [MOCK_HD_ACCOUNT_1],
      });

-      const resyncAccountsSpy = jest.spyOn(service, 'resyncAccounts');
      await messenger.call('MultichainAccountService:resyncAccounts');
-      expect(resyncAccountsSpy).toHaveBeenCalled();
+
+      expect(mocks.EvmAccountProvider.resyncAccounts).toHaveBeenCalled();
+      expect(mocks.SolAccountProvider.resyncAccounts).toHaveBeenCalled();


we can't spy resyncAccounts at this step since registeMethodActionHandlers will register the original method not the spied one

GuillaumeRx · 2026-02-20T13:01:33Z

packages/multichain-account-service/src/MultichainAccountService.test.ts

-      const ensureCanUseSnapPlatformSpy = jest.spyOn(
-        service,
-        'ensureCanUseSnapPlatform',
+      await rootMessenger.call(
+        'MultichainAccountService:ensureCanUseSnapPlatform',
      );
-      await messenger.call('MultichainAccountService:ensureCanUseSnapPlatform');
-      expect(ensureCanUseSnapPlatformSpy).toHaveBeenCalled();


we can't spy ensureCanUseSnapPlatform at this step since registeMethodActionHandlers will register the original method not the spied one

packages/multichain-account-service/src/MultichainAccountService.test.ts

mcmire

Nice! The code changes themselves look good, but I had some suggestions on changelogs. (You may need to add the no-changelog label to this PR to suppress the changelog checker.)

mcmire · 2026-02-20T15:09:18Z

packages/account-tree-controller/src/AccountTreeController.test.ts

+      controller.setAccountGroupName(groupId, 'Suffix Test', true);

-      // Test with no conflicts: should return "Unique Name (2)"
-      const uniqueName = controller.resolveNameConflict(
-        wallet,
-        groupId,
-        'Unique Name',
-      );
-      expect(uniqueName).toBe('Unique Name (2)');
+      const collidingGroupObject = controller.getAccountGroupObject(groupId);
+
+      expect(collidingGroupObject?.metadata.name).toBe('Suffix Test (3)');
+
+      // Test with no conflicts: should return "Unique Name"
+      controller.setAccountGroupName(groupId, 'Unique Name', true);
+
+      const uniqueGroupObject = controller.getAccountGroupObject(groupId);
+
+      expect(uniqueGroupObject?.metadata.name).toBe('Unique Name');


I can confirm this is not used in either extension and mobile.

packages/account-tree-controller/CHANGELOG.md

mcmire · 2026-02-20T15:19:05Z

packages/accounts-controller/src/AccountsController.ts

   * @throws An error if the account ID is not found.
   */
-  getAccountExpect(accountId: string): InternalAccount {
+  #getAccountExpect(accountId: string): InternalAccount {


Makes sense!

packages/account-tree-controller/CHANGELOG.md

packages/multichain-account-service/CHANGELOG.md

packages/notification-services-controller/CHANGELOG.md

packages/profile-metrics-controller/CHANGELOG.md

packages/profile-sync-controller/CHANGELOG.md

packages/subscription-controller/CHANGELOG.md

mcmire

LGTM!

- Update CHANGELOGs - Remove non public-facing changes - Make entries clearer - Remove export of `*MethodActions`

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

packages/profile-sync-controller/src/controllers/user-storage/UserStorageController.ts

GuillaumeRx requested a review from a team as a code owner February 18, 2026 11:14

GuillaumeRx force-pushed the gr/expose-accounts-methods-messenger branch from 7de355d to 0e42ff2 Compare February 18, 2026 11:15

GuillaumeRx commented Feb 18, 2026

View reviewed changes

cursor bot reviewed Feb 18, 2026

View reviewed changes

packages/profile-sync-controller/src/controllers/user-storage/UserStorageController.ts Outdated Show resolved Hide resolved

hmalik88 reviewed Feb 18, 2026

View reviewed changes

packages/profile-sync-controller/src/controllers/user-storage/UserStorageController.ts Outdated Show resolved Hide resolved

mcmire reviewed Feb 18, 2026

View reviewed changes

GuillaumeRx force-pushed the gr/expose-accounts-methods-messenger branch from 0e42ff2 to 6ea2c28 Compare February 19, 2026 15:10

GuillaumeRx requested review from a team as code owners February 19, 2026 15:10

GuillaumeRx commented Feb 19, 2026

View reviewed changes

cursor bot reviewed Feb 19, 2026

View reviewed changes

packages/account-tree-controller/src/types.ts Outdated Show resolved Hide resolved

GuillaumeRx requested review from a team as code owners February 19, 2026 15:30

GuillaumeRx changed the title ~~chore: Expose Accounts-owned controller/service methods through messenger~~ feat!: Expose Accounts-owned controller/service methods through messenger Feb 20, 2026

GuillaumeRx requested a review from a team as a code owner February 20, 2026 10:44

GuillaumeRx force-pushed the gr/expose-accounts-methods-messenger branch 2 times, most recently from be1d092 to 405c239 Compare February 20, 2026 11:19

GuillaumeRx commented Feb 20, 2026

View reviewed changes

GuillaumeRx force-pushed the gr/expose-accounts-methods-messenger branch from 31e2baa to 6867941 Compare February 20, 2026 13:04

cursor bot reviewed Feb 20, 2026

View reviewed changes

packages/multichain-account-service/src/MultichainAccountService.test.ts Show resolved Hide resolved

mcmire reviewed Feb 20, 2026

View reviewed changes

GuillaumeRx added the no-changelog label Feb 23, 2026

GuillaumeRx force-pushed the gr/expose-accounts-methods-messenger branch from 5f0e503 to 2aa9997 Compare February 23, 2026 11:13

GuillaumeRx requested a review from mcmire February 23, 2026 11:33

mcmire previously approved these changes Feb 23, 2026

View reviewed changes

GuillaumeRx enabled auto-merge February 23, 2026 17:53

GuillaumeRx added 21 commits February 24, 2026 14:26

use generate-method-action-types in account-tree-controller

19538b2

use generate-method-action-types in accounts-controller

b1a94d3

use generate-method-action-types in multichain-account-service

2f75dca

use generate-method-action-types in profile-sync-controller

e0c14b7

revert typo

bb9f0fd

fix import

d746685

fix action name usage

1c14840

fix lint and exports

beadfa9

use type only imports

7596219

fix account-tree-controller type imports

8601993

fix lint, rename actions in other controllers

a44156c

fill coverage in AccountsController

f4be972

update CHANGELOGs

82db2cb

fix eslint-suppressions.json lint

8d63c02

fix claims-controller changelog

dda2768

fix multichain-account-service tests

f6875a0

remove direct call to method in test

1de02f4

Address requested changes

0731bd4

- Update CHANGELOGs - Remove non public-facing changes - Make entries clearer - Remove export of `*MethodActions`

fix multichain-account-service CHANGELOG

f05f301

fix CHANGELOGs and package.json after rebase

6a0f46a

fix action types after rebase

73143ae

GuillaumeRx dismissed baptiste-marchand’s stale review via 73143ae February 24, 2026 13:28

GuillaumeRx force-pushed the gr/expose-accounts-methods-messenger branch from 3744ee7 to 73143ae Compare February 24, 2026 13:28

GuillaumeRx added 2 commits February 24, 2026 14:29

re-add comment

603df23

fix CHANGELOG

5705479

cursor bot reviewed Feb 24, 2026

View reviewed changes

packages/profile-sync-controller/src/controllers/user-storage/UserStorageController.ts Show resolved Hide resolved

Mrtenz disabled auto-merge February 24, 2026 14:43

Mrtenz approved these changes Feb 24, 2026

View reviewed changes

Mrtenz merged commit 05f02f9 into main Feb 24, 2026
310 checks passed

Mrtenz deleted the gr/expose-accounts-methods-messenger branch February 24, 2026 14:48

Uh oh!

Conversation

GuillaumeRx commented Feb 18, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation

References

Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mcmire left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mcmire left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

GuillaumeRx commented Feb 18, 2026 •

edited by cursor bot

Loading