Skip to content

Add set_milestone.py#197

Merged
james-bruten-mo merged 2 commits intoMetOffice:mainfrom
jennyhickson:set_milestone
Feb 23, 2026
Merged

Add set_milestone.py#197
james-bruten-mo merged 2 commits intoMetOffice:mainfrom
jennyhickson:set_milestone

Conversation

@jennyhickson
Copy link
Collaborator

PR Summary

Sci/Tech Reviewer:
Code Reviewer: @james-bruten-mo

Extract the function to set all closed pull requests to a milestone into its own script as this is a useful thing to run periodically standalone. finish_milestone.py then imports this routine to make use of it.

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • This change has been tested appropriately (please describe)

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Security considerations have been addressed
  • Performance impact is acceptable

Copy link
Collaborator

@james-bruten-mo james-bruten-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sensible to be able to run this on its own

@james-bruten-mo james-bruten-mo merged commit 535d0fd into MetOffice:main Feb 23, 2026
8 checks passed
@jennyhickson jennyhickson added this to the Spring 2026 milestone Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants