Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #50 +/- ##
==========================================
- Coverage 88.00% 87.94% -0.06%
==========================================
Files 11 11
Lines 2117 2115 -2
==========================================
- Hits 1863 1860 -3
- Misses 254 255 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Alright, so good news and bad news. Good news: This fixes CI on Julia 1.12 Bad news: This breaks CI on Julia 1.9 (which is green on master). So let's try gating the new code on a Julia 1.12+ version check. |
|
Nah let's just make 1.10 the new requirement 🤷 It's fine since it's the LTS. |
|
This is also in #25 BTW though I didn't get around to fixing that. |
|
Sure, I can remove Julia 1.9 from the CI matrix. But Julia 1.9 through 1.11 are all broken the same way by this PR: (example CI log on 1.11) So I think we still need to gate some of this logic on Julia 1.12+ vs Julia <1.12. |
da18369 to
43ce89b
Compare
|
Honestly yeah might as well. There was a race condition I was trying to debug at the time but that I can look at later. |
|
Done. |
a63f144 to
3df8c78
Compare
3df8c78 to
ae51712
Compare
|
Alright, this PR now consists only of the CI changes. |
|
Thanks ❤️ Note that there are some test failures on master, most likely because LibSSH.jl isn't threadsafe and 1.12 has an interactive thread by default. You can ignore those failures, I'll fix it at some point. |
To get CI green, should we just disable the interactive thread? E.g. something like |
|
Yeah I think this environment variable might need to be changed to DistributedNext.jl/test/runtests.jl Line 17 in d8f44f5 |
The default interactive thread didn't exist in Julia 1.11 and earlier
|
Okay, it looks like killing workers doesn't work on Julia 1.10 on Windows. (IIUC, it didn't work on Julia 1.9 on Windows either.) Windows seems fine on Julia 1.11, 1.12, and nightly. So I'll exclude Julia 1.10 on Windows. |
|
Alright, so the only CI failures here are on macOS, which as I mentioned above, are also seen on master. I think this is good to go from my point-of-view. |
archcorrectly on each