Ensure correct type parameter of serialized RemoteChannel (forwardport of JuliaLang/Distributed.jl#179)#36
Closed
DilumAluthge wants to merge 1 commit intomasterfrom
Closed
Ensure correct type parameter of serialized RemoteChannel (forwardport of JuliaLang/Distributed.jl#179)#36DilumAluthge wants to merge 1 commit intomasterfrom
DilumAluthge wants to merge 1 commit intomasterfrom
Conversation
DilumAluthge
force-pushed
the
dpa/179-forward-port
branch
from
6272995 to
20a29cc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #36 +/- ##
===========================================
- Coverage 88.00% 78.00% -10.01%
===========================================
Files 11 11
Lines 2117 2041 -76
===========================================
- Hits 1863 1592 -271
- Misses 254 449 +195 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DilumAluthge
changed the title
Member
Author
|
I can combine this with other forwardports in the forwardport PR (#49), if desired. |
DilumAluthge
changed the title
This is a forward-port of JuliaLang/Distributed.jl#179 (JuliaLang/Distributed.jl@6649a94). When serializing RemoteChannels, a new zeroed RemoteChannel is constructed. However, the input type parameter might be part of an outer type parameter which can then lead to a TypeError during deserialization. The fix is just to reuse the type parameter of the input when constructing the zeroed RemoteChannel. (cherry picked from commit 6649a94075ff6a52ee9558db3ec4491496bf1bea)
DilumAluthge
force-pushed
the
dpa/179-forward-port
branch
from
20a29cc to
2e52996
Compare
Member
Author
|
I've combined this into #49 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a forward-port of JuliaLang/Distributed.jl#179. cc: @andreasnoack