Add support for multiple Trino JSON functions#2382
Open
davyboyhayes wants to merge 1 commit intoJSQLParser:masterfrom
Open
Add support for multiple Trino JSON functions#2382davyboyhayes wants to merge 1 commit intoJSQLParser:masterfrom
davyboyhayes wants to merge 1 commit intoJSQLParser:masterfrom
Conversation
Adding support for clauses in JSON Functions. Fixes JSQLParser#2368 Adds support for the extra clauses found in Trino's JSON functions https://trino.io/docs/current/functions/json.html#json-exists, and includes test cases for these extra functions directly taken from the documentations. Before: Result "net.sf.jsqlparser.benchmark.JSQLParserBenchmark.parseSQLStatements": 34.858 ±(99.9%) 1.724 ms/op [Average] (min, avg, max) = (32.578, 34.858, 38.383), stdev = 2.302 CI (99.9%): [33.133, 36.582] (assumes normal distribution) After: Result "net.sf.jsqlparser.benchmark.JSQLParserBenchmark.parseSQLStatements": 36.154 ±(99.9%) 1.701 ms/op [Average] (min, avg, max) = (33.100, 36.154, 38.353), stdev = 2.271 CI (99.9%): [34.453, 37.855] (assumes normal distribution)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for clauses in JSON Functions. Fixes #2368
Adds support for the extra clauses found in Trino's JSON functions https://trino.io/docs/current/functions/json.html#json-exists, and includes test cases for these extra functions directly taken from the documentations.
Before:
Result "net.sf.jsqlparser.benchmark.JSQLParserBenchmark.parseSQLStatements":
34.858 ±(99.9%) 1.724 ms/op [Average]
(min, avg, max) = (32.578, 34.858, 38.383), stdev = 2.302
CI (99.9%): [33.133, 36.582] (assumes normal distribution)
After:
Result "net.sf.jsqlparser.benchmark.JSQLParserBenchmark.parseSQLStatements":
36.154 ±(99.9%) 1.701 ms/op [Average]
(min, avg, max) = (33.100, 36.154, 38.353), stdev = 2.271
CI (99.9%): [34.453, 37.855] (assumes normal distribution)