Conversation
Signed-off-by: Vishu Bhatnagar <vishu.bhatnagar@ibm.com>
…ove-admin-privileges-from-the-other-admin-user
…ove-admin-privileges-from-the-other-admin-user
Member
|
Hi @vishu-bh,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
Closes # #2808
📝 Summary
What does this PR do and why?
This PR fixes thes issue When an admin user tries to remove the admin privileges from the other admin user, API returns error message. It should not return an error message untill it is the last admin.
Key Changes:
The root cause was: There is a flag in config called 'protect_all_admins'. This flag is set to true by in configuration. Hence, it was restricting other admins to demote other admins.
🏷️ Type of Change
🧪 Verification
make lintmake testmake coverage✅ Checklist
make black isort pre-commit)📓 Notes (optional)
Screenshots, design decisions, or additional context.