Draft
Conversation
Instead of running "git submodule update --init --recursive" and then relying on "git fleximod test" to make sure the submodules match what git fleximod expects, the test now runs "git fleximod update" and then uses "git diff --exit-code" to see if that's different than what git submodules expect. This is a "six of one, half dozen of the other" type change, but is consistent with what was discussed at a CSEG meeting. I also cleaned up some white space.
Collaborator
Author
|
This currently keeps |
Collaborator
Author
|
@alperaltuntas should we close this? I think the existing test works well enough, and there's also the testing done in ESCOMP/CESM so it's probably not worth figuring out whatever I was trying to change here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of running
git submodule update --init --recursiveand then relying ongit fleximod testto make sure the submodules match what git fleximod expects, the test now runsgit fleximod updateand then usesgit diff --exit-codeto see if that's different than what git submodules expect. This is a "six of one, half dozen of the other" type change, but is consistent with what was discussed at a CSEG meeting.I also cleaned up some white space.