Draft
Conversation
Audit found no real secrets in any repo history, broken baseline audit check, and ~10x workflow overhead vs gitleaks. Aligns with DLS org recommendation. - Replace ~100-line detect-secrets CI workflow with gitleaks-action - Add .gitleaks.toml allowlist for docs/claude-code/k8s false positives - Switch pre-commit hook from detect-secrets to gitleaks pre-push - Add gitleaks pre-push command to lefthook - Remove .secrets.baseline - Add ADR-0018, supersede ADR-0005 Ref: #139
github-actions
bot
added
documentation
vredchenko
added
admin
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.gitleaks.tomlallowlist for known false positives (docs, claude-code, k8s templates).secrets.baselineContext
Audit of all DLS repos found no real secrets in git history, a broken baseline audit check (
is_secretkey absent vsnull), and ~10x workflow overhead. Aligns with DLS org recommendation for gitleaks.Ref: #139
Test plan
gitleaks detect --source .locally confirms no unhandled findingsgitleaks protect --staged --redact)