Draft
Conversation
This repo previously had no secret scanning. Add gitleaks to align with all other DLS repos. - Add gitleaks CI workflow - Add lefthook with gitleaks pre-push hook - Add lefthook as devDependency with prepare script - Add empty .gitleaks.toml (no known false positives) Note: run `pnpm install` to update lockfile after merging. Ref: DiamondLightSource/smartem-devtools#139 See: ADR-0018 in smartem-devtools
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"prepare": "lefthook install"script.gitleaks.tomlplaceholder (no known false positives)Context
Audit of all DLS repos found that sci-react-ui was the only repo without any secret scanning. Adding gitleaks aligns it with the other four DLS repos.
Ref: DiamondLightSource/smartem-devtools#139
See: ADR-0018 in smartem-devtools
Test plan
gitleaks detect --source .locally confirms no findingspnpm installto generate lockfile update (not included in this PR)gitleaks protect --staged --redact)