PivotGrid - ♿️ Handle Accessibility restrictions#32583
Open
aleksei-semikozov wants to merge 4 commits intoDevExpress:26_1from
Open
PivotGrid - ♿️ Handle Accessibility restrictions#32583aleksei-semikozov wants to merge 4 commits intoDevExpress:26_1from
aleksei-semikozov wants to merge 4 commits intoDevExpress:26_1from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request aims to fix accessibility violations in PivotGrid components by handling ARIA attributes appropriately in the PivotGrid field chooser. The changes address aria-allowed-attr violations that were previously being ignored in accessibility tests.
Changes:
- Overrides the
_setAriaSortAttributemethod inFieldChooserBaseto customize ARIA attribute handling for PivotGrid field chooser elements - Removes ignored accessibility test rules for five PivotGrid demos, indicating these violations should now be fixed
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
packages/devextreme/js/__internal/grids/pivot_grid/field_chooser/m_field_chooser_base.ts |
Adds _setAriaSortAttribute method override to customize ARIA attributes for PivotGrid field chooser elements |
apps/demos/testing/common.test.ts |
Removes ignored aria-allowed-attr rules for PivotGrid demos, expecting the accessibility violations to be fixed |
packages/devextreme/js/__internal/grids/pivot_grid/field_chooser/m_field_chooser_base.ts
Show resolved
Hide resolved
packages/devextreme/js/__internal/grids/pivot_grid/field_chooser/m_field_chooser_base.ts
Show resolved
Hide resolved
sjbur
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.