Removing Wrong Spark Spans for Inactive Databricks Clusters#10651
Draft
larakulkarni1 wants to merge 6 commits intomasterfrom
Draft
Removing Wrong Spark Spans for Inactive Databricks Clusters#10651larakulkarni1 wants to merge 6 commits intomasterfrom
larakulkarni1 wants to merge 6 commits intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~de2d1b6f9f, baseline=1.60.0-SNAPSHOT~be0482d740
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.068 s) : 0, 1068008
Total [baseline] (8.772 s) : 0, 8771833
Agent [candidate] (1.063 s) : 0, 1062695
Total [candidate] (8.713 s) : 0, 8712512
section iast
Agent [baseline] (1.238 s) : 0, 1238323
Total [baseline] (9.358 s) : 0, 9357755
Agent [candidate] (1.228 s) : 0, 1227931
Total [candidate] (9.325 s) : 0, 9325229
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~de2d1b6f9f, baseline=1.60.0-SNAPSHOT~be0482d740
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (629.863 ms) : 0, 629863
BytebuddyAgent [candidate] (627.062 ms) : 0, 627062
AgentMeter [baseline] (29.166 ms) : 0, 29166
AgentMeter [candidate] (28.95 ms) : 0, 28950
GlobalTracer [baseline] (258.005 ms) : 0, 258005
GlobalTracer [candidate] (257.397 ms) : 0, 257397
AppSec [baseline] (33.14 ms) : 0, 33140
AppSec [candidate] (32.97 ms) : 0, 32970
Debugger [baseline] (62.888 ms) : 0, 62888
Debugger [candidate] (61.809 ms) : 0, 61809
Remote Config [baseline] (630.545 µs) : 0, 631
Remote Config [candidate] (614.58 µs) : 0, 615
Telemetry [baseline] (11.553 ms) : 0, 11553
Telemetry [candidate] (9.848 ms) : 0, 9848
Flare Poller [baseline] (5.377 ms) : 0, 5377
Flare Poller [candidate] (6.749 ms) : 0, 6749
section iast
crashtracking [baseline] (1.213 ms) : 0, 1213
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (801.609 ms) : 0, 801609
BytebuddyAgent [candidate] (794.432 ms) : 0, 794432
AgentMeter [baseline] (11.514 ms) : 0, 11514
AgentMeter [candidate] (11.254 ms) : 0, 11254
GlobalTracer [baseline] (247.84 ms) : 0, 247840
GlobalTracer [candidate] (246.948 ms) : 0, 246948
AppSec [baseline] (33.284 ms) : 0, 33284
AppSec [candidate] (33.84 ms) : 0, 33840
Debugger [baseline] (66.881 ms) : 0, 66881
Debugger [candidate] (65.0 ms) : 0, 65000
Remote Config [baseline] (538.94 µs) : 0, 539
Remote Config [candidate] (540.472 µs) : 0, 540
Telemetry [baseline] (8.656 ms) : 0, 8656
Telemetry [candidate] (8.594 ms) : 0, 8594
Flare Poller [baseline] (3.516 ms) : 0, 3516
Flare Poller [candidate] (3.472 ms) : 0, 3472
IAST [baseline] (27.199 ms) : 0, 27199
IAST [candidate] (26.771 ms) : 0, 26771
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~de2d1b6f9f, baseline=1.60.0-SNAPSHOT~be0482d740
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1064738
Total [baseline] (11.064 s) : 0, 11063806
Agent [candidate] (1.063 s) : 0, 1062835
Total [candidate] (10.93 s) : 0, 10930078
section appsec
Agent [baseline] (1.239 s) : 0, 1238845
Total [baseline] (10.956 s) : 0, 10955572
Agent [candidate] (1.245 s) : 0, 1244979
Total [candidate] (10.993 s) : 0, 10992742
section iast
Agent [baseline] (1.232 s) : 0, 1231935
Total [baseline] (11.223 s) : 0, 11222779
Agent [candidate] (1.232 s) : 0, 1231684
Total [candidate] (11.142 s) : 0, 11141648
section profiling
Agent [baseline] (1.187 s) : 0, 1187446
Total [baseline] (11.031 s) : 0, 11030526
Agent [candidate] (1.199 s) : 0, 1199495
Total [candidate] (10.862 s) : 0, 10861853
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~de2d1b6f9f, baseline=1.60.0-SNAPSHOT~be0482d740
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (627.252 ms) : 0, 627252
BytebuddyAgent [candidate] (626.688 ms) : 0, 626688
AgentMeter [baseline] (28.996 ms) : 0, 28996
AgentMeter [candidate] (28.953 ms) : 0, 28953
GlobalTracer [baseline] (258.483 ms) : 0, 258483
GlobalTracer [candidate] (257.243 ms) : 0, 257243
AppSec [baseline] (33.142 ms) : 0, 33142
AppSec [candidate] (32.865 ms) : 0, 32865
Debugger [baseline] (64.851 ms) : 0, 64851
Debugger [candidate] (64.155 ms) : 0, 64155
Remote Config [baseline] (626.694 µs) : 0, 627
Remote Config [candidate] (620.119 µs) : 0, 620
Telemetry [baseline] (10.22 ms) : 0, 10220
Telemetry [candidate] (9.913 ms) : 0, 9913
Flare Poller [baseline] (3.86 ms) : 0, 3860
Flare Poller [candidate] (5.344 ms) : 0, 5344
section appsec
crashtracking [baseline] (1.21 ms) : 0, 1210
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (657.868 ms) : 0, 657868
BytebuddyAgent [candidate] (662.049 ms) : 0, 662049
AgentMeter [baseline] (11.877 ms) : 0, 11877
AgentMeter [candidate] (12.019 ms) : 0, 12019
GlobalTracer [baseline] (258.49 ms) : 0, 258490
GlobalTracer [candidate] (259.834 ms) : 0, 259834
AppSec [baseline] (167.849 ms) : 0, 167849
AppSec [candidate] (167.825 ms) : 0, 167825
Debugger [baseline] (66.712 ms) : 0, 66712
Debugger [candidate] (66.546 ms) : 0, 66546
Remote Config [baseline] (637.058 µs) : 0, 637
Remote Config [candidate] (626.574 µs) : 0, 627
Telemetry [baseline] (9.357 ms) : 0, 9357
Telemetry [candidate] (9.494 ms) : 0, 9494
Flare Poller [baseline] (3.675 ms) : 0, 3675
Flare Poller [candidate] (3.67 ms) : 0, 3670
IAST [baseline] (25.258 ms) : 0, 25258
IAST [candidate] (25.563 ms) : 0, 25563
section iast
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (796.191 ms) : 0, 796191
BytebuddyAgent [candidate] (796.325 ms) : 0, 796325
AgentMeter [baseline] (11.313 ms) : 0, 11313
AgentMeter [candidate] (11.28 ms) : 0, 11280
GlobalTracer [baseline] (247.849 ms) : 0, 247849
GlobalTracer [candidate] (247.325 ms) : 0, 247325
AppSec [baseline] (35.375 ms) : 0, 35375
AppSec [candidate] (33.153 ms) : 0, 33153
Debugger [baseline] (64.339 ms) : 0, 64339
Debugger [candidate] (66.814 ms) : 0, 66814
Remote Config [baseline] (548.227 µs) : 0, 548
Remote Config [candidate] (534.833 µs) : 0, 535
Telemetry [baseline] (8.653 ms) : 0, 8653
Telemetry [candidate] (8.671 ms) : 0, 8671
Flare Poller [baseline] (3.475 ms) : 0, 3475
Flare Poller [candidate] (3.466 ms) : 0, 3466
IAST [baseline] (27.081 ms) : 0, 27081
IAST [candidate] (27.018 ms) : 0, 27018
section profiling
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (678.835 ms) : 0, 678835
BytebuddyAgent [candidate] (689.599 ms) : 0, 689599
AgentMeter [baseline] (8.593 ms) : 0, 8593
AgentMeter [candidate] (8.573 ms) : 0, 8573
GlobalTracer [baseline] (215.48 ms) : 0, 215480
GlobalTracer [candidate] (216.72 ms) : 0, 216720
AppSec [baseline] (32.496 ms) : 0, 32496
AppSec [candidate] (32.755 ms) : 0, 32755
Debugger [baseline] (66.867 ms) : 0, 66867
Debugger [candidate] (67.468 ms) : 0, 67468
Remote Config [baseline] (636.12 µs) : 0, 636
Remote Config [candidate] (650.673 µs) : 0, 651
Telemetry [baseline] (9.129 ms) : 0, 9129
Telemetry [candidate] (9.021 ms) : 0, 9021
Flare Poller [baseline] (3.747 ms) : 0, 3747
Flare Poller [candidate] (3.729 ms) : 0, 3729
ProfilingAgent [baseline] (100.192 ms) : 0, 100192
ProfilingAgent [candidate] (98.546 ms) : 0, 98546
Profiling [baseline] (100.782 ms) : 0, 100782
Profiling [candidate] (99.107 ms) : 0, 99107
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 19 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~de2d1b6f9f, baseline=1.60.0-SNAPSHOT~be0482d740
dateFormat X
axisFormat %s
section baseline
no_agent (1.17 ms) : 1159, 1182
. : milestone, 1170,
iast (3.223 ms) : 3179, 3268
. : milestone, 3223,
iast_FULL (5.568 ms) : 5513, 5622
. : milestone, 5568,
iast_GLOBAL (3.618 ms) : 3552, 3684
. : milestone, 3618,
profiling (2.081 ms) : 2063, 2100
. : milestone, 2081,
tracing (1.776 ms) : 1761, 1792
. : milestone, 1776,
section candidate
no_agent (1.184 ms) : 1173, 1195
. : milestone, 1184,
iast (3.141 ms) : 3101, 3180
. : milestone, 3141,
iast_FULL (5.643 ms) : 5588, 5699
. : milestone, 5643,
iast_GLOBAL (3.55 ms) : 3491, 3608
. : milestone, 3550,
profiling (1.985 ms) : 1967, 2003
. : milestone, 1985,
tracing (1.796 ms) : 1781, 1810
. : milestone, 1796,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~de2d1b6f9f, baseline=1.60.0-SNAPSHOT~be0482d740
dateFormat X
axisFormat %s
section baseline
no_agent (17.913 ms) : 17735, 18091
. : milestone, 17913,
appsec (18.402 ms) : 18215, 18588
. : milestone, 18402,
code_origins (17.527 ms) : 17354, 17700
. : milestone, 17527,
iast (19.026 ms) : 18834, 19218
. : milestone, 19026,
profiling (18.634 ms) : 18446, 18822
. : milestone, 18634,
tracing (17.791 ms) : 17615, 17967
. : milestone, 17791,
section candidate
no_agent (18.148 ms) : 17962, 18333
. : milestone, 18148,
appsec (18.212 ms) : 18024, 18400
. : milestone, 18212,
code_origins (17.514 ms) : 17340, 17688
. : milestone, 17514,
iast (17.664 ms) : 17490, 17839
. : milestone, 17664,
profiling (18.817 ms) : 18625, 19009
. : milestone, 18817,
tracing (17.454 ms) : 17279, 17629
. : milestone, 17454,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~de2d1b6f9f, baseline=1.60.0-SNAPSHOT~be0482d740
dateFormat X
axisFormat %s
section baseline
no_agent (15.048 s) : 15048000, 15048000
. : milestone, 15048000,
appsec (14.845 s) : 14845000, 14845000
. : milestone, 14845000,
iast (18.206 s) : 18206000, 18206000
. : milestone, 18206000,
iast_GLOBAL (17.789 s) : 17789000, 17789000
. : milestone, 17789000,
profiling (14.899 s) : 14899000, 14899000
. : milestone, 14899000,
tracing (14.854 s) : 14854000, 14854000
. : milestone, 14854000,
section candidate
no_agent (14.999 s) : 14999000, 14999000
. : milestone, 14999000,
appsec (14.987 s) : 14987000, 14987000
. : milestone, 14987000,
iast (18.199 s) : 18199000, 18199000
. : milestone, 18199000,
iast_GLOBAL (17.703 s) : 17703000, 17703000
. : milestone, 17703000,
profiling (14.773 s) : 14773000, 14773000
. : milestone, 14773000,
tracing (14.696 s) : 14696000, 14696000
. : milestone, 14696000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~de2d1b6f9f, baseline=1.60.0-SNAPSHOT~be0482d740
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (3.794 ms) : 3571, 4016
. : milestone, 3794,
iast (2.251 ms) : 2182, 2320
. : milestone, 2251,
iast_GLOBAL (2.295 ms) : 2226, 2364
. : milestone, 2295,
profiling (2.079 ms) : 2025, 2134
. : milestone, 2079,
tracing (2.075 ms) : 2021, 2128
. : milestone, 2075,
section candidate
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (3.769 ms) : 3548, 3990
. : milestone, 3769,
iast (2.254 ms) : 2185, 2324
. : milestone, 2254,
iast_GLOBAL (2.307 ms) : 2237, 2377
. : milestone, 2307,
profiling (2.076 ms) : 2022, 2131
. : milestone, 2076,
tracing (2.063 ms) : 2010, 2117
. : milestone, 2063,
|
8bf15a0 to
fb1450e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.