Skip to content

[Common] Fix stale Q/Pt values in TrackTuner graph-based smearing #15174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joonsukbae wants to merge 2 commits into
base: master
Choose a base branch
from
+35 −30
Open

[Common] Fix stale Q/Pt values in TrackTuner graph-based smearing #15174

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6c4c38
[Common] Fix stale Q/Pt values in TrackTuner graph-based smearing
joonsukbae Feb 25, 2026
43abedd
Rename currentQOverPt -> smearQOverPt per review
joonsukbae Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 35 additions & 30 deletions Common/Tools/TrackTuner.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -755,19 +755,24 @@ struct TrackTuner : o2::framework::ConfigurableGroup {
dcaZResMC = evalGraph(ptMC, grDcaZResVsPtPionMC[phiBin].get());
dcaZResData = evalGraph(ptMC, grDcaZResVsPtPionData[phiBin].get());

// For Q/Pt corrections, files on CCDB will be used if both qOverPtMC and qOverPtData are null
// Local Q/Pt resolution: either the constant configurable value, or evaluated per-track from graphs
double smearQOverPtMC = qOverPtMC;
double smearQOverPtData = qOverPtData;
if (updateCurvature || updateCurvatureIU) {
if ((qOverPtMC < 0) || (qOverPtData < 0)) {
if (debugInfo) {
LOG(info) << "### q/pt smearing: qOverPtMC=" << qOverPtMC << ", qOverPtData=" << qOverPtData << ". One of them is negative. Retrieving then values from graphs from input .root file";
}
if ((smearQOverPtMC < 0) || (smearQOverPtData < 0)) {
/// check that input graphs for q/pt smearing are correctly retrieved
if (!grOneOverPtPionData.get() || !grOneOverPtPionMC.get()) {
LOG(fatal) << "### q/pt smearing: input graphs not correctly retrieved. Aborting.";
}
qOverPtMC = std::max(0.0, evalGraph(ptMC, grOneOverPtPionMC.get()));
qOverPtData = std::max(0.0, evalGraph(ptMC, grOneOverPtPionData.get()));
} // qOverPtMC, qOverPtData block ends here
smearQOverPtMC = std::max(0.0, evalGraph(ptMC, grOneOverPtPionMC.get()));
smearQOverPtData = std::max(0.0, evalGraph(ptMC, grOneOverPtPionData.get()));
if (debugInfo) {
LOG(info) << "### q/pt graph-based smearing: pT=" << ptMC
<< " sigma(1/pT)_MC=" << smearQOverPtMC
<< " sigma(1/pT)_Data=" << smearQOverPtData
<< " ratio(Data/MC)=" << (smearQOverPtMC > 0. ? smearQOverPtData / smearQOverPtMC : -1.);
}
} // smearQOverPtMC, smearQOverPtData block ends here
} // updateCurvature, updateCurvatureIU block ends here

if (updateTrackDCAs) {
Expand Down Expand Up @@ -836,44 +841,44 @@ struct TrackTuner : o2::framework::ConfigurableGroup {
// double dpt1o =pt1o-pt1mc;
deltaQpt = trackParQPtMCRec - trackParQPtMC;
// double dpt1n =dpt1o *(spt1o >0. ? (spt1n /spt1o ) : 1.);
deltaQptTuned = deltaQpt * (qOverPtMC > 0. ? (qOverPtData / qOverPtMC) : 1.);
deltaQptTuned = deltaQpt * (smearQOverPtMC > 0. ? (smearQOverPtData / smearQOverPtMC) : 1.);
// double pt1n = pt1mc+dpt1n;
trackParQPtTuned = trackParQPtMC + deltaQptTuned;
trackParCov.setQ2Pt(trackParQPtTuned);

// updating track cov matrix elements for 1/Pt at innermost update point
// if(sd0rpo>0. && spt1o>0.)covar[10]*=(sd0rpn/sd0rpo)*(spt1n/spt1o);//ypt
sigma1PtY = trackParCov.getSigma1PtY();
if (dcaXYResMC > 0. && qOverPtMC > 0.) {
sigma1PtY *= ((dcaXYResData / dcaXYResMC) * (qOverPtData / qOverPtMC));
if (dcaXYResMC > 0. && smearQOverPtMC > 0.) {
sigma1PtY *= ((dcaXYResData / dcaXYResMC) * (smearQOverPtData / smearQOverPtMC));
trackParCov.setCov(sigma1PtY, 10);
}

// if(sd0zo>0. && spt1o>0.) covar[11]*=(sd0zn/sd0zo)*(spt1n/spt1o);//zpt
sigma1PtZ = trackParCov.getSigma1PtZ();
if (dcaZResMC > 0. && qOverPtMC > 0.) {
sigma1PtZ *= ((dcaZResData / dcaZResMC) * (qOverPtData / qOverPtMC));
if (dcaZResMC > 0. && smearQOverPtMC > 0.) {
sigma1PtZ *= ((dcaZResData / dcaZResMC) * (smearQOverPtData / smearQOverPtMC));
trackParCov.setCov(sigma1PtZ, 11);
}

// if(spt1o>0.) covar[12]*=(spt1n/spt1o);//sinPhipt
sigma1PtSnp = trackParCov.getSigma1PtSnp();
if (qOverPtMC > 0.) {
sigma1PtSnp *= (qOverPtData / qOverPtMC);
if (smearQOverPtMC > 0.) {
sigma1PtSnp *= (smearQOverPtData / smearQOverPtMC);
trackParCov.setCov(sigma1PtSnp, 12);
}

// if(spt1o>0.) covar[13]*=(spt1n/spt1o);//tanTpt
sigma1PtTgl = trackParCov.getSigma1PtTgl();
if (qOverPtMC > 0.) {
sigma1PtTgl *= (qOverPtData / qOverPtMC);
if (smearQOverPtMC > 0.) {
sigma1PtTgl *= (smearQOverPtData / smearQOverPtMC);
trackParCov.setCov(sigma1PtTgl, 13);
}

// if(spt1o>0.) covar[14]*=(spt1n/spt1o)*(spt1n/spt1o);//ptpt
sigma1Pt2 = trackParCov.getSigma1Pt2();
if (qOverPtMC > 0.) {
sigma1Pt2 *= (qOverPtData / qOverPtMC) * (qOverPtData / qOverPtMC);
if (smearQOverPtMC > 0.) {
sigma1Pt2 *= (smearQOverPtData / smearQOverPtMC) * (smearQOverPtData / smearQOverPtMC);
trackParCov.setCov(sigma1Pt2, 14);
}
} // updateCurvatureIU block ends here
Expand Down Expand Up @@ -969,7 +974,7 @@ struct TrackTuner : o2::framework::ConfigurableGroup {
}
deltaQpt = trackParQPtMCRec - trackParQPtMC;
// double dpt1n =dpt1o *(spt1o >0. ? (spt1n /spt1o ) : 1.);
deltaQptTuned = deltaQpt * (qOverPtMC > 0. ? (qOverPtData / qOverPtMC) : 1.);
deltaQptTuned = deltaQpt * (smearQOverPtMC > 0. ? (smearQOverPtData / smearQOverPtMC) : 1.);
// double pt1n = pt1mc+dpt1n;
trackParQPtTuned = trackParQPtMC + deltaQptTuned;
trackParCov.setQ2Pt(trackParQPtTuned);
Expand Down Expand Up @@ -1030,36 +1035,36 @@ struct TrackTuner : o2::framework::ConfigurableGroup {
if ((updateCurvature) && (!updateCurvatureIU)) {
// if(sd0rpo>0. && spt1o>0.)covar[10]*=(sd0rpn/sd0rpo)*(spt1n/spt1o);//ypt
sigma1PtY = trackParCov.getSigma1PtY();
if (dcaXYResMC > 0. && qOverPtMC > 0.) {
sigma1PtY *= ((dcaXYResData / dcaXYResMC) * (qOverPtData / qOverPtMC));
if (dcaXYResMC > 0. && smearQOverPtMC > 0.) {
sigma1PtY *= ((dcaXYResData / dcaXYResMC) * (smearQOverPtData / smearQOverPtMC));
trackParCov.setCov(sigma1PtY, 10);
}

// if(sd0zo>0. && spt1o>0.) covar[11]*=(sd0zn/sd0zo)*(spt1n/spt1o);//zpt
sigma1PtZ = trackParCov.getSigma1PtZ();
if (dcaZResMC > 0. && qOverPtMC > 0.) {
sigma1PtZ *= ((dcaZResData / dcaZResMC) * (qOverPtData / qOverPtMC));
if (dcaZResMC > 0. && smearQOverPtMC > 0.) {
sigma1PtZ *= ((dcaZResData / dcaZResMC) * (smearQOverPtData / smearQOverPtMC));
trackParCov.setCov(sigma1PtZ, 11);
}

// if(spt1o>0.) covar[12]*=(spt1n/spt1o);//sinPhipt
sigma1PtSnp = trackParCov.getSigma1PtSnp();
if (qOverPtMC > 0.) {
sigma1PtSnp *= (qOverPtData / qOverPtMC);
if (smearQOverPtMC > 0.) {
sigma1PtSnp *= (smearQOverPtData / smearQOverPtMC);
trackParCov.setCov(sigma1PtSnp, 12);
}

// if(spt1o>0.) covar[13]*=(spt1n/spt1o);//tanTpt
sigma1PtTgl = trackParCov.getSigma1PtTgl();
if (qOverPtMC > 0.) {
sigma1PtTgl *= (qOverPtData / qOverPtMC);
if (smearQOverPtMC > 0.) {
sigma1PtTgl *= (smearQOverPtData / smearQOverPtMC);
trackParCov.setCov(sigma1PtTgl, 13);
}

// if(spt1o>0.) covar[14]*=(spt1n/spt1o)*(spt1n/spt1o);//ptpt
sigma1Pt2 = trackParCov.getSigma1Pt2();
if (qOverPtMC > 0.) {
sigma1Pt2 *= (qOverPtData / qOverPtMC) * (qOverPtData / qOverPtMC);
if (smearQOverPtMC > 0.) {
sigma1Pt2 *= (smearQOverPtData / smearQOverPtMC) * (smearQOverPtData / smearQOverPtMC);
trackParCov.setCov(sigma1Pt2, 14);
}
} // ---> track cov matrix elements for 1/Pt ends here
Expand Down
Loading