[O2B-1536] Add lastEditiedBy name to EOR reason section of the run-details page#2090
Draft
isaachilly wants to merge 6 commits intomainfrom
Draft
[O2B-1536] Add lastEditiedBy name to EOR reason section of the run-details page#2090isaachilly wants to merge 6 commits intomainfrom
isaachilly wants to merge 6 commits intomainfrom
Conversation
Now display the lastEditedName for EOR reasons on `run-detail` page. `formatEorReason` also renders a tooltip above the `lastEditedName` to make clear who it refers to.
Adjust expectations to include displayed author 'Anonymous' on a new line.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2090 +/- ##
==========================================
- Coverage 45.63% 45.61% -0.02%
==========================================
Files 1039 1040 +1
Lines 17324 17331 +7
Branches 3148 3150 +2
==========================================
Hits 7905 7905
- Misses 9419 9426 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add a dedicated eorReasonComponent that renders the EOR reason VDOM.
Stop keeping a separate `eorReasonLastEditedNames` list on RunDetailsModel and instead include `lastEditedName` on each eorReason within RunPatch. RunPatch `toPojo` then strips that field when building the outbound patch. This removes duplicate state and ensures only allowed fields are sent to the server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
Changes made to the database: