Export-DbaInstance: Enhance handling of dedicated admin connections (#10173)

Author: andreasjordan

private/testing/Get-TestConfig.ps1

@@ -25,25 +25,25 @@ function Get-TestConfig {
         Write-Host -Object "Get-TestConfig: Setting up test configuration for AppVeyor"  -ForegroundColor DarkGreen
 
         if ($env:InstanceSingle) {
-            $config['InstanceSingle'] = "$(hostname)\$($env:InstanceSingle)"
+            $config['InstanceSingle'] = "$env:COMPUTERNAME\$env:InstanceSingle"
         }
         if ($env:InstanceMulti1) {
-            $config['InstanceMulti1'] = "$(hostname)\$($env:InstanceMulti1)"
+            $config['InstanceMulti1'] = "$env:COMPUTERNAME\$env:InstanceMulti1"
         }
         if ($env:InstanceMulti2) {
-            $config['InstanceMulti2'] = "$(hostname)\$($env:InstanceMulti2)"
+            $config['InstanceMulti2'] = "$env:COMPUTERNAME\$env:InstanceMulti2"
         }
         if ($env:InstanceCopy1) {
-            $config['InstanceCopy1'] = "$(hostname)\$($env:InstanceCopy1)"
+            $config['InstanceCopy1'] = "$env:COMPUTERNAME\$env:InstanceCopy1"
         }
         if ($env:InstanceCopy2) {
-            $config['InstanceCopy2'] = "$(hostname)\$($env:InstanceCopy2)"
+            $config['InstanceCopy2'] = "$env:COMPUTERNAME\$env:InstanceCopy2"
         }
         if ($env:InstanceHadr) {
-            $config['InstanceHadr'] = "$(hostname)\$($env:InstanceHadr)"
+            $config['InstanceHadr'] = "$env:COMPUTERNAME\$env:InstanceHadr"
         }
         if ($env:InstanceRestart) {
-            $config['InstanceRestart'] = "$(hostname)\$($env:InstanceRestart)"
+            $config['InstanceRestart'] = "$env:COMPUTERNAME\$env:InstanceRestart"
         }
 
         $config['SQLUserName'] = $null  # placeholders for -SqlCredential testing

public/Export-DbaInstance.ps1

@@ -217,17 +217,39 @@ function Export-DbaInstance {
         foreach ($instance in $SqlInstance) {
             $stepCounter = 0
             try {
-                $server = Connect-DbaInstance -SqlInstance $instance -SqlCredential $SqlCredential -MinimumVersion 10
+                # Do we need a dedicated admin connection for password retrieval?
+                # If not both are excluded, we do
+                $dacNeeded = $Exclude -notcontains 'Credentials' -or $Exclude -notcontains 'LinkedServers'
+                # If passwords are excluded, we don't need a DAC
+                if ($ExcludePassword) { $dacNeeded = $false }
+
+                # Do we have a dedicated admin connection already?
+                $dacConnected = $instance.Type -eq 'Server' -and $instance.InputObject.Name -match '^ADMIN:'
+
+                $dacOpened = $false
+                if ($dacNeeded) {
+                    if ($dacConnected) {
+                        Write-Message -Level Verbose -Message "Reusing dedicated admin connection for password retrieval."
+                        $server = $instance.InputObject
+                    } else {
+                        Write-Message -Level Verbose -Message "Opening dedicated admin connection for password retrieval."
+                        $server = Connect-DbaInstance -SqlInstance $instance -SqlCredential $SqlCredential -MinimumVersion 10 -DedicatedAdminConnection -WarningAction SilentlyContinue
+                        $dacOpened = $true
+                    }
+                } else {
+                    Write-Message -Level Verbose -Message "Opening or reusing normal connection because passwords are excluded."
+                    $server = Connect-DbaInstance -SqlInstance $instance -SqlCredential $SqlCredential -MinimumVersion 10
+                }
             } catch {
                 Stop-Function -Message "Failure" -Category ConnectionError -ErrorRecord $_ -Target $instance -Continue
             }
 
             if ($Force) {
                 # when the caller requests to overwrite existing scripts we won't add the dynamic timestamp to the folder name, so that a pre-existing location can be overwritten.
-                $exportPath = Join-DbaPath -Path $Path -Child "$($server.name.replace('\', '$'))"
+                $exportPath = Join-DbaPath -Path $Path -Child "$($server.DomainInstanceName.replace('\', '$'))"
             } else {
                 $timeNow = (Get-Date -UFormat (Get-DbatoolsConfigValue -FullName 'formatting.uformat'))
-                $exportPath = Join-DbaPath -Path $Path -Child "$($server.name.replace('\', '$'))-$timeNow"
+                $exportPath = Join-DbaPath -Path $Path -Child "$($server.DomainInstanceName.replace('\', '$'))-$timeNow"
             }
 
             # Ensure the export dir exists.
@@ -264,7 +286,7 @@ function Export-DbaInstance {
             if ($Exclude -notcontains 'Credentials') {
                 Write-Message -Level Verbose -Message "Exporting SQL credentials"
                 Write-ProgressHelper -StepNumber ($stepCounter++) -Message "Exporting SQL credentials"
-                $null = Export-DbaCredential -SqlInstance $server -FilePath "$exportPath\credentials.sql" -ExcludePassword:$ExcludePassword
+                $null = Export-DbaCredential -SqlInstance $server -Credential $Credential -FilePath "$exportPath\credentials.sql" -ExcludePassword:$ExcludePassword
                 Get-ChildItem -ErrorAction Ignore -Path "$exportPath\credentials.sql"
             }
 
@@ -447,6 +469,9 @@ function Export-DbaInstance {
                 Get-ChildItem -ErrorAction Ignore -Path "$exportPath\oledbprovider.sql"
             }
 
+            if ($dacOpened) {
+                $null = $server | Disconnect-DbaInstance -WhatIf:$false
+            }
 
             Write-Progress -Activity "Performing Instance Export for $instance" -Completed
         }

tests/Export-DbaInstance.Tests.ps1

@@ -60,7 +60,6 @@ Describe $CommandName -Tag IntegrationTests {
 
         # registered server and group
         $testServer = $TestConfig.InstanceSingle
-        $server = Connect-DbaInstance -SqlInstance $testServer
         $srvName = "dbatoolsci-server1"
         $group = "dbatoolsci-group1"
         $regSrvName = "dbatoolsci-server12"
@@ -260,6 +259,22 @@ Describe $CommandName -Tag IntegrationTests {
         $results.Length | Should -BeGreaterThan 0
     }
 
+    It "Export credentials without passwords" {
+        $results = Export-DbaInstance -SqlInstance $testServer -Path $exportDir -Exclude 'AgentServer', 'Audits', 'AvailabilityGroups', 'BackupDevices', 'CentralManagementServer', 'CustomErrors', 'DatabaseMail', 'Databases', 'Endpoints', 'ExtendedEvents', 'LinkedServers', 'Logins', 'PolicyManagement', 'ReplicationSettings', 'ResourceGovernor', 'ServerAuditSpecifications', 'ServerRoles', 'SpConfigure', 'SysDbUserObjects', 'SystemTriggers', 'OleDbProvider' -ExcludePassword
+
+        $results.FullName | Should -Exist
+        $results.Length | Should -BeGreaterThan 0
+    }
+
+    It "Export credentials with preopend dac" {
+        $dac = Connect-DbaInstance -SqlInstance $testServer -DedicatedAdminConnection
+        $results = Export-DbaInstance -SqlInstance $dac -Path $exportDir -Exclude 'AgentServer', 'Audits', 'AvailabilityGroups', 'BackupDevices', 'CentralManagementServer', 'CustomErrors', 'DatabaseMail', 'Databases', 'Endpoints', 'ExtendedEvents', 'LinkedServers', 'Logins', 'PolicyManagement', 'ReplicationSettings', 'ResourceGovernor', 'ServerAuditSpecifications', 'ServerRoles', 'SpConfigure', 'SysDbUserObjects', 'SystemTriggers', 'OleDbProvider' -ExcludePassword
+        $null = $dac | Disconnect-DbaInstance
+
+        $results.FullName | Should -Exist
+        $results.Length | Should -BeGreaterThan 0
+    }
+
     It "Export logins" {
         $results = Export-DbaInstance -SqlInstance $testServer -Path $exportDir -Exclude 'AgentServer', 'Audits', 'AvailabilityGroups', 'BackupDevices', 'CentralManagementServer', 'Credentials', 'CustomErrors', 'DatabaseMail', 'Databases', 'Endpoints', 'ExtendedEvents', 'LinkedServers', 'PolicyManagement', 'ReplicationSettings', 'ResourceGovernor', 'ServerAuditSpecifications', 'ServerRoles', 'SpConfigure', 'SysDbUserObjects', 'SystemTriggers', 'OleDbProvider'